Skip to content

docs: translate to Japanese tutorials.md #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 19, 2025
Merged

docs: translate to Japanese tutorials.md #469

merged 9 commits into from
May 19, 2025

Conversation

tkoyama010
Copy link
Member

ref #352

@tkoyama010 tkoyama010 marked this pull request as draft April 20, 2025 03:25
@tkoyama010 tkoyama010 marked this pull request as ready for review April 20, 2025 03:28
@tkoyama010 tkoyama010 requested a review from flpm April 20, 2025 23:04
@flpm
Copy link
Member

flpm commented May 19, 2025 •
edited
Loading

The CI and my fail with this error:

/home/felipe/github/pyOpenSci/python-package-guide/tutorials/command-line-reference.md:8:<translated>:1: WARNING: 'myst' cross-reference target not found: 'Windows' [myst.xref_missing]

flpm
flpm requested changes May 19, 2025
View reviewed changes
Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small issue with the build, I think I traced it to the cause.

@flpm flpm added the lang-JA label May 19, 2025
tkoyama010
tkoyama010 commented May 19, 2025
View reviewed changes
@flpm flpm self-requested a review May 19, 2025 20:01
flpm
flpm approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

@flpm flpm merged commit 334c946 into main May 19, 2025
4 checks passed
@flpm flpm deleted the tutorial branch May 19, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flpm flpm flpm approved these changes

Assignees
No one assigned
Labels
lang-JA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkoyama010 @flpm